adjusted tests to do compare server side#90
Closed
bryantaustin13 wants to merge 1 commit intocqframework:mainfrom
Closed
adjusted tests to do compare server side#90bryantaustin13 wants to merge 1 commit intocqframework:mainfrom
bryantaustin13 wants to merge 1 commit intocqframework:mainfrom
Conversation
Contributor
Author
|
This fix is not appropriate. We need to test client side NOT server side, because we need to insure that the server is returning the proper things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes these tests
LowerEmpty (actual undefined vs '')
SplitABNull (actual "a,b" vs list of {'a,b'})
SplitABDash (actual "a,b" vs list of {'a,b'})
UpperEmpty (actual undefined vs '')
By changing the compare to server side so translation from return value problems do not interfere.
See the following for test notes
cqframework/cql-tests-runner#63